macGui: x264 Advanced preset strings, if user has specified a default string in prefs, it is used and the most recent one (whether manually entered or from a preset) is not used.
-Built in presets now use all values in their dictionary to make the .plist more compatible for export to the CLI
33 lines of code changed in:
MacGui: Advanced Tab initial implementation
- Sets groundwork for more robust x264 advanced options implementation
- currently strings are displayed and editable via textfield for x264 encodes
- for right now, the x264 string from preferences is ignored, need to figure out best way to implement that string.
- New Preset now takes the value from that field in advanced, negating the need for the field in "Add new Preset" window.
- NOTE: this also implements the new "Use Picture Settings" in presets to allow for "None", Use Current","Use Max from source".
48 lines of code changed in:
macGui: Change the Growl encode done notification to be the same as the onscreen notification. Thanks jbrjake!
1 lines of code changed in:
macGui: Growl Support initial implementation
- include Growl.framework in xcode project
- Growl notify when encode is done
- fix cancelled encode finished bug
- may want a user pref to let them select if they want a notification and what type, on screen or grow. or both
- right now, its both.
2888 lines of code changed in:
macGui: Encode Done Notification initial implementation
- System alert sound as well as an NSAlert window to notify the user their encode is completed.
- No dock icon bounce yet.
15 lines of code changed in:
Various fixes:
- Include parsecsv.c in the Jamfile so we can compile the CLI with Jam
- Quiet some compiler warnings in parsecsv.{c,h}
- Check some return values in muxmp4.c and encfaac.c and die gracefully if there is a problem.
- Correctly set the number of audio channels in the stsd atom.
80 lines of code changed in:
MacGui: Presets and Main Menu
- Add PSP built in preset for jbrjake ;)
- Move "Presets" main menu item to the left of "Window"
- Use "Update Built-In Presets" to use PSP preset.
69 lines of code changed in:
MacGui: Queue modifications
- Queue is now integral to encoding
- removed "Enable Queue" Checkbox
- made "Add to Queue" and "Show queue" always usable
- Rip method in controller.mm always calls addToQueue even for one rip, but then automatically rips it.
- Added queue status field.
- fixes bug in 0.8.5 where having queue enabled and clicking rip with nothing in the queue causes HB to do nothing.
26 lines of code changed in:
Named Chapter Markers build fix
- xcode project required to successfully build.
- failed on previous commit.
- This should be last thing for successful build
20 lines of code changed in:
Fix Previous Bad commit for Cyanders Chapter Markers
714 lines of code changed in:
Cyanders Named Chapter Markers
- Thanks Cyander
4 lines of code changed in:
MacGui: Correct Version to 0.8.5b1 in all references to HandBrake.app
- This corrects the version number in the get info window
36 lines of code changed in:
Nests the pdf directory inside the doc directory, for the "make release" .dmg
1 lines of code changed in:
Updates "make release" to use proper intercapping (HandBrake not Handbrake) and to include the pdf manuals in the disk image.
1 lines of code changed in:
Credit Nyx's b-frame work
3 lines of code changed in:
Tidied up the Mac OS X GUI prefs window layout a bit
1 lines of code changed in:
AUTHORS file claimed to be for "MediaFork previously HandBrake" - changed to just be HandBrake
1 lines of code changed in:
Updated AUTHORS file to shout about all the extra bits I've added for 0.8.5b1:)
4 lines of code changed in:
Fixed PrefsController.m so that the default prefs are correctly used when a user has never run HandBrake before.
19 lines of code changed in:
Getting the Jamrules and Makefile.config ready for the return of the update checker.
- Ends HB_BUILD with an odd number, denoting an unstable (beta) build
- Updates HB_VERSION in Jamrules to 0.8.5b1
The LATEST file still needs to be iterated on the webserver, after which update checking can be switched on.
4 lines of code changed in:
MacGui: update Built-In Presets to all use a 48 khz audio sample rate.
2 lines of code changed in:
Improved the bitrate in Controller.mm to deal with different bitrates for different codecs, to avoid disappointed users, and applications crashes.
Instated a max of 320 kbps for MP3, as it won't encode at 384. Instated a min of 48 kbps for Vorbis, as it crashes if anything lower is selected.
Changed the approach to setting and retrieving the bitrates slightly, to use the NSPopUpButton's menuitem tags to store the bitrate for each item (since not all menus will have all items).
79 lines of code changed in:
MacGui: Initial implementation of capping avialable bitrates depending on audio track mixdown
- added AudioTrackMixdownChanged method to controller.mm which evaluates other selections and adjusts available bitrates to choose from
- currently just caps bitrates at 160 for anything other than 6 channel discrete
- 6 channel discrete in either audio track mixdown enables bitrates up to 384.
- Will likely need to add other conditions as well
32 lines of code changed in:
Small change to Controller.mm to ensure that Stereo is offered as a mixdown when we have a mono audio source but a non-mono-supporting output codec. Previously, no mixdown was being offered in this situation.
10 lines of code changed in:
This change stops Presets from saving and loading "language / audio format" track selections (the "Track 1/2" popups) and mixdowns (the "Track 1/2 Mix" popups) in the Mac OS GUI. In practice, this was causing more confusion than the default behaviour.
0 lines of code changed in:
Add 384 kbps to Audio Bitrates selection for use with 6 channel discrete
- We still need to filter out which bitrates are available depending on mixdown. Right now, you can select 320 in gui for a stereo track even though libhb limits it to 160, so its misleading.
1 lines of code changed in:
MacGui: Added HandBrake Users Guide under the Help menu. Links to our wiki guide.
8 lines of code changed in:
MacGui: Replace the "Rip" button with "Start". As we are generally removing reference to ripping in regard to HandBrake ... even though it sort of still can.
6 lines of code changed in:
MacGui: Minor cosmetic changes
- Change preset buttons "+", "-", and drawer toggle buttons to the Small Square type
- Blame jbrjake if you don't like them :)
2 lines of code changed in:
MacGui: Cosmetic change and default pref change
- Make CRF the default method for Constant Quality encodes
- Change the "Audio" tab to "Audio & Subtitles" so people dont get all in an uproar about where the subtitles are located
3 lines of code changed in:
MacGui: Clean up a few things w/x264optstring prefs and presets
- Change abr of AppleTV built in preset to 2500 kbps
- Note: as usual, after updating your copy, use "Update Built-In Presets" in the presets menu for changes to take effect.
- Fix so that closing picture window does not reset the preset chosen display to "Custom"
- Add a user preference to show or hide the chosen x264 option strings in the main gui window. Defaults to off.
47 lines of code changed in:
Improved the Mac OS GUI's handling of language / audio track settings in presets. It is now much better placed to deal with scenarios where the preset's saved language / audio setting doesn't have a match in the selected title's audio list.
So, e.g. if you insert a disk with a title with only mono AC3 tracks, but the preset is "English AC3 5.1", then it will default to selecting the first audio track rather than selecting "None".
In making these changes, I've also added some utility functions to Controller.mm - one to add all audio tracks for a title to a popup menu, and one to select a track in a popup menu based on a search prefix string. These are really just tidying up what was already there in a reusable way.
73 lines of code changed in:
Removed all references to the old job->surround variable, as it is no longer used. Also, removed the "Extract 5.1 Dolby Digital to 6-Channel AAC" preference option from the Mac OS GUI prefs window and controller, as it is no longer needed. It may be worth adding in a new "Default mixdown" preference in its place for a future version of Handbrake?
3 lines of code changed in:
MacGui: Picture Preview - Anamorphic
- Properly show the anamorhic height instead of output height.
- This distorts the preview picture in HB's Picture Preview, but is actually correct.
31 lines of code changed in:
Cleaning up the code a bit.
194 lines of code changed in:
64-bit data atoms break some consumer devices. We need to figure out a smarter way of doing this.
1 lines of code changed in:
Fix a major memory leak introduced in Nyx's bframe patch.
0 lines of code changed in:
Successfully create MP4 files bigger than 4GB
1 lines of code changed in:
Prevents a bus error at the end of muxing when b-frames are enabled.
3 lines of code changed in:
MacGui: Fix Presets mangling the x264 option strings for the umpteenth time.
- Replace the Optional x264 string NSTextView with an NSTextField
- Change when the field is emptied after creation.
- Reset the value of the ChickenSandwich.
44 lines of code changed in:
Re-organized so make is the preferred build method, standardized some text layout stuff, and removed a stray reference to libmediafork.
40 lines of code changed in:
MacGui: Presets Built in changes-
-iPod add x264 opt string: "frameref=1:bframes=0:nofast_pskip:subq=6:partitions=p8x8,p8x4,p4x8,i4x4:qcomp=0:me=umh:nodct_decimate", 1500 kbps abr and 48 samplerate and 160 kbps dpl2 audio
- AppleTV add x264 opt string: "bframes=3:ref=1:subme=5:me=umh:no-fast-pskip=1:no-dct-decimate=1:trellis=2"
7 lines of code changed in:
Much better B-frame muxing frame-reordering. This will preserve the sps/pps info, properly offset the first frame, and flush any remaining frames at the end of the encode.
Patch by: Nyx
210 lines of code changed in:
Fixed a bug in the Mac GUI (Controller.mm), introduced in rev 511, whereby selecting "none" on an audio popup when "none" was already selected on the other audio popup would cause an infinite loop, leading to a crash.
Changed the audio popup logic in PrepareJob to use the second audio track settings as the first audio track when the first audio track is set to "none" but the second audio track has a source track selected.
23 lines of code changed in:
Amended controller.mm to prevent the user from selecting the same audio track twice in the Mac GUI. This is because we are currently unable to extract the same track twice without ending up with silence in the second audio.
Amended a few calls to AudioTrackPopUpChanged to use the convenience version of this function, which passes in a mixdownToUse value of 0.
19 lines of code changed in:
Unbreak the build! Yay. (Should have been part of r508).
8 lines of code changed in:
hb_log is for libhb; use fprintf like the rest of the file.
11 lines of code changed in:
Cleaning up some compiler warnings.
5 lines of code changed in:
Bump HB_VERSION to 0.8.5b1 for regular builds, 0.8.5s for snapshot builds
2 lines of code changed in:
Placed the changelog in the NEWS file.
80 lines of code changed in:
Updated links (dynalias to m0k.org) and added some "make" build comments in BUILD for the CYGWIN environment.
421 lines of code changed in:
Cleaned up the windows changelog and removed some details that really were not required.
65 lines of code changed in:
MacGui: Fix x264 options strings in the queue by implementing patch from Nyx. Thanks Nyx!
- x264 options passing to the queue no longer crash HandBrake.
28 lines of code changed in:
MacGui: Show x264 options string right under the "Encoder" drop down in main window if x264 is selected and any advanced x264 options strings are going to be used. This fields reads any in presets and if a preset isnt selected, looks to see if any will be used from the preferences NSTextView.
- Temporary location most likely for debugging
- May move to another location
- May add a preference to toggle this info field on or off ?
9 lines of code changed in:
MacGui: Attempt to fix x264 options in Presets.
- Empty the new preset opt string field right after creation.
- Verify new string are created in tact.
13 lines of code changed in:
MacGui: Presets - modify built in presets to work with the new audio formats. Make the x264 option strings available to all x264 profiles instead of just main profile
Built In Preset Changes:
- PS3: Change level to 41, audio one track, 160 kbps DPL2 mixdown
- AppleTV: Change Audio to one track, 160 kbps DPL2 mixdown
- iPod: Change Audio to one track, 128 kbps Stereo Mixdown
26 lines of code changed in:
MacGui: Presets now utilize Audio Mixdowns Thanks maurj!
- Added second audio track support in presets
- Mixdowns regress gracefully depending on current dvd source
- Source Track 2 sets to "None" if one is specified that doesn't exist in current dvd.
Note: in initial testing, second track using 6 channel kills encode performance and yields a track with no sound. Needs to be tested and verified. Main track works flawlessly in initial testing.
114 lines of code changed in:
Changelog updated for Windows GUI
24 lines of code changed in:
Updated the Mac GUI to use the new audio mixdowns. This means that the Mac GUI now supports Dolby PRo Logic 2 mixdowns!
The Audio tab now has two mixdown NSPopUpButtons, which are set to display all of the possible mixdowns for the current input audio codec / output audio codec / input audio channel configuration.
A mixdown of HB_AMIXDOWN_DOLBYPLII is used by default (or the next best mixdown if this isn't possible). Ideally this will become a prefs option to specify your choice of default audio mixdown.
For AC3 passthru, a single mixdown of "AC3 Passthru" is displayed.
I've had to update the Xcode project file, to make the Handbrake target look for headers in the "../contrib/include" folder too. This is so that it can find the a52 headers which are now used by Controller.mm.
I've added an ac3flags property to hb_audio_s, to enable us to access the source ac3 flags outside of libhb. This is set in scan.c for each source audio.
I've updated hb_mixdown_s and the hb_audio_mixdowns[] to include the CLI "short name" version of the mixdowns too, ready for the Mac GUI "default mixdown" prefs saving / loading.
248 lines of code changed in:
Made a small change to test.c to explicitly select the first audio track, and use the default mixdown, if no audio track has been specified via the -a option. This fixes a crash in rev 495 when no audio track was specified.
1010 lines of code changed in:
Checking in macosx/Controller.mm, which should have been included with rev 494. it contains some changes to make the Mac GUI compile with the new audio mixdown code.
1 lines of code changed in:
Added libhb and CLI support for Dolby Pro Logic II 5.0 matrix encoding. *NOT YET ADDED TO THE GUI*. Handbrake now uses a more general "audio mixdown" concept. For each audio track to be converted you specify a mixdown. These are defined in common.h.
This checkin only allows you to specify one mixdown for all tracks in the CLI, although everything is in place internally to specify a different mixdown per track. In the CLI, the "-6 --surround" option has been repurposed as a "-6 --mixdown" option, with a string parameter of mono/stereo/dpl1/dpl2/6ch.
327 lines of code changed in:
MacGui: Framerate Revert changes back to "Same as Source" from rev 492
3 lines of code changed in:
MacGui: Framerate
- Deprecate "Same as source"
- Use "23.976" as default
- All presets previously using "Same as source" will automatically use "23.976" instead without modification
12 lines of code changed in:
MacGui: Presets - fix bug where editing the preset name corrupts the x264 option strings in the presets
- expand the hidden x264 option string display debugging field in the main window.
2 lines of code changed in:
gtk2 and wx gui's are no longer used. Removed to save bandwidth.
0 lines of code changed in:
Added Changelog.rtf to allow editing.
66 lines of code changed in:
Added some documentation:
1. Change log for Handbrake 0.8.5b1 & Win GUI 2.2b1
2. FAQ for the Windows GUI
0 lines of code changed in:
Contrib binaries with maurj patch to a52 for ProLogic II
1 lines of code changed in:
MacGui: Built In Presets
- Modify both AppleTV and PS3 to use 2500 abr
- Modify PS3 x264 opts to "level=30" only
- as always remember to update your built in presets in the presets menu when updating working copy.
3 lines of code changed in:
Pre-compiled version of a52dec updated with maurj's patch included.
2 lines of code changed in:
Added patch file to jamfile for maurj's liba52 patch
2 lines of code changed in:
Added a new patch file, to patch liba52 to support a Dolby Pro Logic II matrix encoding. Note: this patch file isn't yet integrated into the Jam process, and the DPLII support in Handbrake isn't yet committed. I've really only committed the patch so that someone kind (Prigaux?) can add it to the Jam process, and therefore patch the precompiled contrib library download.
The changes in this patch are backwards-compatible, i.e. the contrib library download can be updated and used without breaking the current projects.
2 lines of code changed in:
MacGui: Add PS3 Built in Preset. This needs to be tested by someone that has one (read: clee)
75 lines of code changed in:
MacGui: Last source directory used is now remembered and used the next time instead of being reset by browsing for a new destination directory each time.
20 lines of code changed in:
MacGui: Presets Menu now in Main Menu bar
- New "Update Built-in Presets" function automatically deletes existing built in presets and creates new up to date ones
- New "Delete Built-in Presets" deletes all built in presets
- "New Preset ..." accesses the new preset window
44 lines of code changed in:
Corrected small EOL marker issue.
12 lines of code changed in:
Uploaded new contrib packaged which is compiled under GCC4 - Fixes many stack dump issues under CYGWIN
12 lines of code changed in:
MacGui: disable Vorbis 6 channel encoding since it is broken in libhb.
6 lines of code changed in:
Ooops. Restores xvid-in-mp4 functionality, which I broke with b-frame muxing. (Thanks for the bug report, superdump, and thanks for pointing out where the problem was, saintdev.)
3 lines of code changed in:
MacGui: x264 options in presets - initial implementation
- x264 options string can be entered in NSTextview in the create new preset window
NOTE:
- When using x264, the gui first looks for a preset with a x264 option string available and then looks for the string in the preferences if it cant find it in the preset. So, if there is a string available in the preset, it ignores the string (if there is one available) in the prefs.
71 lines of code changed in:
maurj reported a double-free crash that I am unable to reproduce. This removes an extra free that appears to be the problem. Better to leak a little memory than have some users crash.
0 lines of code changed in:
Fix a bus error if b-pyramid is given as an x264 option without specifying a value. (Thanks for alerting me to the bug, saintdev)
13 lines of code changed in:
Amended work.c to remember the number of source A52 channels and lfe channels, so that deca52.c can correctly detect a 5.1 source which needs mixing down to Dolby Digital. Previously it was just mixing 5.1 down to stereo. This has been broken since rev 438, when the multi-soundtrack bug was fixed.
5 lines of code changed in:
Oops, got a little to unalloc-happy. Fixes a crash.
0 lines of code changed in:
Fix several MB of memory leaks in lame, and vorbis.
6ch Vorbis doesn't seem quite ready for prime time.
28 lines of code changed in: