Main page
[17:44] [jbrjake] just like if it's AC3 the mixdown popup should only have the AC3 PassThru as its sole item
[17:44] [dynaflash] jbrajake: maurj
[17:44] [dynaflash] oops
[17:45] [dynaflash] maurj's code to populate the mixdown dropdowns is based on what AC3 is avail from source
[17:45] [dynaflash] for aac
[17:45] [jbrjake] ....
[17:45] [jbrjake] i thought we were doing this like eddyg's rev 1?
[17:45] [dynaflash] if we have an ac3 2.0 source, the mixdown popup code for aac will break if it only has dpl2 allowed
[17:46] [jbrjake] the mixdown popup code for aac has nothing to do with it
[17:46] [jbrjake] it should only be used for H.264/AAC in the codec popup
[17:46] [dynaflash] forget it
[17:46] [jbrjake] the mixdown popup for this doppelganger shit should have one, constant item
[17:47] [jbrjake] "DPL2 and AC3 Pass-Thru"
[17:47] [jbrjake] there is no reason for it to change depending on the source audio channels
[17:48] [dynaflash] and how the hell do you propose to get the DPL2 part of that from an AC3 2.0 source ?
[17:48] [jbrjake] huh?
[17:48] [jbrjake] like i said
[17:48] [dynaflash] you have to be kidding me
[17:48] [jbrjake] it degrades gracefully
[17:48] [jbrjake] in libhb
[17:48] [sr55] someone has changed someone which has broken something
[17:48] [sr55] badly
[17:49] [jbrjake] [11:48:40] + 80bd, English (AC3) (Dolby Surround)
[17:49] [jbrjake] [11:48:40] + Requested mixdown: Dolby Pro Logic II (HB_AMIXDOWN_DOLBYPLII)
[17:49] [jbrjake] [11:48:40] + Actual mixdown: Dolby Surround (HB_AMIXDOWN_DOLBY)
[17:49] [jbrjake] [11:48:40] + 80bd, English (AC3) (Dolby Surround)
[17:49] [jbrjake] [11:48:40] + Requested mixdown: AC-3 Pass-through (HB_AMIXDOWN_AC3)
[17:49] [jbrjake] [11:48:40] + Actual mixdown: AC-3 Pass-through (HB_AMIXDOWN_AC3)
[17:49] [jbrjake] that's using a 2.0 track
[17:49] [sr55] folders include and lib are no longer being genreated as folders. They are being generated as files
[17:52] [jbrjake] i checked my commits today, they look fine in trac... no issues here
[17:55] [sr55] ok, I can't figure out why this isn't working :/
[17:55] [sr55] hopeless bit of softare this thing is :/
[17:57] [sr55] ok, defo not a code issue :(
[18:04] sr55 (n=Scott@62-31-67-171.cable.ubr01.livi.blueyonder.co.uk) left irc: Read error: 104 (Connection reset by peer)
[18:07] sr55 (n=Scott@62-31-67-171.cable.ubr01.livi.blueyonder.co.uk) joined #handbrake-dev.
[18:08] #handbrake-dev: mode change '+o sr55' by BrakeBot!n=BrakeBot@rocky.lapsus.org
[18:08] #handbrake-dev: mode change '+o sr55' by HandBot!n=HandBot@213.246.52.12
[19:17] [dynaflash] I presume we do not want users to be able to use the new hybrid with mkv and avi like they can now in the gui, right ?
[19:22] *** jbrjake would hold off on that til audio can be totally overhauled
[19:33] [sr55] ok, i'm baffled. Stock CYGWIN can no longer complain with jam :S
[19:33] [jbrjake] maybe connected to saintdev's nasm changes?
[19:34] [sr55] went back to rev 1000
[19:34] [sr55] nogo
[19:34] [sr55] it simply refuses to create lib and include folders in the contrib directory
[19:34] [sr55] rebuilt jam. reinstalled cygwin
[19:34] [sr55] nada
[19:36] [dynaflash] k. gonna run some test encodes now, gui is pretty close
[19:37] [dynaflash] ... and we dont want just ac3 pass thru as a mp4 option, right ?
[19:38] [jbrjake] well i'd use it but i have it in the cli so i won't complain if it isn't there in the gui codecs popup ;
[19:39] JayInSF (n=JayInSF@c-67-164-13-209.hsd1.ca.comcast.net) joined #handbrake-dev.
[19:40] [dynaflash] oh, its really easy to take it in or out.
[19:40] [dynaflash] er, I should say if this hack is working
[19:42] [dynaflash] [12:39:51] + Requested mixdown: Dolby Pro Logic II (HB_AMIXDOWN_DOLBYPLII)
[19:42] [dynaflash] [12:39:51] + Actual mixdown: Dolby Pro Logic II (HB_AMIXDOWN_DOLBYPLII)
[19:42] [dynaflash] [12:39:51] + 80bd, English (AC3) (5.1 ch)
[19:42] [dynaflash] [12:39:51] + Requested mixdown: AC-3 Pass-through (HB_AMIXDOWN_AC3)
[19:42] [dynaflash] [12:39:51] + Actual mixdown: AC-3 Pass-through (HB_AMIXDOWN_AC3)
[19:42] [dynaflash] yay
[19:46] [dynaflash] damn this is alot of combos to test
[19:49] [dynaflash] k. qt is showing the right tracks
[19:50] [dynaflash] gotta change a title name to match, and figure out why the default preset is now showing a blank codecs popup in current svn
[19:58] [dynaflash] heres a diff if anyone wants to check it out: http://pastebin.ca/906465
[19:59] [Cavalicious] Question: When you have the two tracks, by default the "stereo" track is the only one enabled. Does the AppleTV play the surround track by default, reguardless if its disabled?
[19:59] [dynaflash] I still havent figured out what broke the codecs popup for the preset
[19:59] [dynaflash] yes
[19:59] [dynaflash] the intro from the atv shows that way in qt
[19:59] [Cavalicious] ok, thats what I thought
[20:00] [hbrbot] ::hb_trac:: Telecine edited by jbrjake @ http://trac.handbrake.fr/wiki/Telecine
[20:00] [hbrbot] ::hb_trac:: Splits telecining info off to its own article.
[20:01] [dynaflash] Cavalicious: can you apply that patch and try some test encodes just to verify you are getting the right stuff ?
[20:02] [Cavalicious] Ok, I need to reencode 3:10 Yuma anyway
[20:02] [Cavalicious] any particular settings?
[20:04] [dynaflash] a couple single chapter tests between the two aac and hybrid settings to make sure your getting what is says you should get, if you can
[20:05] [Cavalicious] ok
[20:05] [dynaflash] ty
[20:06] [dynaflash] once we are settled on it. I will add the preset code
[20:07] [dynaflash] oh, and fyI: you will notice the codecs popup truncates the hybrid part. That is fixed but I didnt want to include the nib in the diff
[20:07] [hbrbot] ::hb_trac:: VariableFrameRate edited by jbrjake @ http://trac.handbrake.fr/wiki/VariableFrameRate
[20:07] [hbrbot] ::hb_trac:: Links in new Telecine page and removes redundant info, significantly streamlining the article. (diff: http://trac.handbrake.fr/wiki/VariableFrameRate?action=diff&version=4)
[20:10] [dynaflash] Oh, good the codecs issue was just with a preset I made before the hybrid method was changed.
[20:10] [dynaflash] old presets work fine
[20:12] [Cavalicious] jam'in now. I had to checkout 1269, I was still o 1265
[20:13] [dynaflash] k. If this works okay, I would like to check it in first. Then do the presets code in a separate checkin
[20:15] [dynaflash] way cool, two language hybrid works fine with the correct (title 1) dpl2 track enabled :)
[20:17] [Cavalicious] of couse, I may get different results than you with my chumped c2d :p
[20:18] [jbrjake] i'm starting to think i want to hold off on introducing comb detection to the svn at all before 0.9.2, for the selfish reason that i don't feel like updating the deinterlacing guide to explain it ;
[20:19] [dynaflash] Note: 2 language hybrids just play the dpl2 track for the first language on the atv
[20:20] [dynaflash] must get confused by the presence of two ac3 tracks or something
[20:20] [dynaflash] same exact source, etc. with one language hybrid the atv plays the dolby track
[20:22] [dynaflash] Note: getting no chirp at all that eddyg said he was getting
[20:24] [Cavalicious] If I choose AVC/H.264 Video /ACC + AC3 Audio, would it make more sense to default Track 1 to Dolby PLII + AC-3?
[20:24] [dynaflash] well, if we leave just ac-3 in there I could add code that does that I spose.
[20:24] [Cavalicious] instead of AC-3 Pass-thru
[20:25] [dynaflash] right, I can add that if we leave it in there. If we lose it and just use dpl2 then its not an issue
[20:25] [dynaflash] :)
[20:25] [Cavalicious] I can see users (like myself) not paying attention and screwing up
[20:25] [Cavalicious] ok
[20:26] [dynaflash] Or, to be truly accurate, we should just use the hybrid there, and add an ac3 only opt back into the codecs menu, tbh
[20:26] [dynaflash] cause really having just ac3 passthru in the hybrid codecs is wrong
[20:26] [jbrjake] yep
[20:27] [dynaflash] fixed
[20:27] [Cavalicious] agreed
[20:27] [sr55] really, users compiling code = bad idea. Probably shouldn't tell them to do it
[20:27] [sr55] they are generally stupid
[20:27] [Cavalicious] I guess I started that...my fault
[20:29] [dynaflash] k. Do we want an ac3 passthru only opt in the gui for mp4 ?
[20:30] [dynaflash] only reason I could think of is playing ac3 pass thru in an mp4 with qt and perian, I guess
[20:31] [Cavalicious] well...does it make any sense to use AC3 Dolby Surround mixed to AC-3 Passthru?
[20:31] [dynaflash] nah, this would just be ac3 passthru like it was in his first implementation
[20:32] *** Cavalicious thinking...
[20:32] *** Cavalicious loking at his other non 5.1 reciever
[20:33] [NightStorm] if it isnt 5.1, i would just mixdown using aac
[20:33] [NightStorm] although some people might want to keep it ac3
[20:33] [Cavalicious] thats what I'm thinking
[20:33] [dynaflash] lol. no this would be in addition to the hybrid
[20:34] [Cavalicious] what about TVs with buit-in Tuners?
[20:34] [dynaflash] hybrid
[20:34] [Cavalicious] gotcha
[20:35] [dynaflash] as I said, in *addition* to hybrid
[20:35] [Cavalicious] ok...sounds fin to me then
[20:37] [jbrjake] huh? wait? what?
[20:37] [Cavalicious] ...round 8
[20:37] *** jbrjake is trying to update the surroundsoundguide as you guys are discussing this, probably a fool's errand ;p
[20:38] [jbrjake] personally, i would use ac3 pass-through alone, and there are cases i'd want it for 2.0 ac3 sound. but i can do it from the cli, and i don't know how popular it would be with the general public.
[20:39] [dynaflash] *shrugs* I dont think I would ever use it tbh
[20:40] [Cavalicious] I think there are plenty of people that float their ATV between the livingroom and the bedroom (or have 2 ATVs), thus AC3 alone isn't going to be an option for them
[20:41] *** jbrjake is thinking ahead though
[20:41] [jbrjake] to that hopefully inevitable day
[20:41] [jbrjake] when vlc plays them
[20:41] [jbrjake] at which point some people currently using mkv or avi for ac3 pass-thru will want to switch
[20:41] [Cavalicious] I'm down for leaving it open for the user to pick whichever combo then want (ofcouse this means they are limited to just 2 tracks in the GUI)
[20:41] [jbrjake] eugh
[20:42] [Cavalicious] its what they're used too anyway
[20:42] [Cavalicious] I mean is there really any BAD combo?
[20:43] [Cavalicious] SHIT HB just crashed on me
[20:44] [dynaflash] during encoding or using the gui ?
[20:45] [Cavalicious] during encoding....
[20:45] [Cavalicious] http://pastebin.ca/906530
[20:47] [Cavalicious] 1st one went fine, Ibelieve it was on the 2nd in queue
[20:54] [dynaflash] If the interface seems to work, I'd like to check it in with just the hybrid before adding the ac3 pass thru option
[20:54] [dynaflash] objections ?
[20:55] [jbrjake] hell i'd like it if you kept it with just the hybrid ;p
[20:55] [Cavalicious] did the crash have anything to do with anything?
[20:55] [jbrjake] i think maybe eddy's audio mixdown code doesn't respect the queue
[20:55] [jbrjake] at least, it looks like faac is initialized with no tracks
[20:56] [Cavalicious] it was encoding the normal acc stuff at the time
[20:56] [Cavalicious] I believe
[20:57] [Cavalicious] Oh ...I know what it was
[20:58] [Cavalicious] let me check something
[21:00] [Cavalicious] ok...It was on my third in queue. Which was a "let me see what would happen" setup (Track 1 = DPLII + AC3 Pass Thru and Track 2 = AC3 Pass Thru from a AC3 Dolby Surround Source)
[21:00] [Cavalicious] Guess I found out what happens
[21:02] [Cavalicious] I don't know if you want to safycheck that
[21:03] [Cavalicious] safty
[21:05] [Cavalicious] safety - its the paint fumes
[21:07] [eddyg] Note that I said yesterday that someone needs to check the queue, and that the combo mixdown is split into two tracks with real mixdowns
[21:08] [eddyg] I'm no longer sure of the structure of the queue code, and was too busy to check.
[21:08] [eddyg] dynaflash: your diff looks fine.
[21:08] [jbrjake] does the queue still get wiped if you cancel an encode?
[21:09] [eddyg] I personally like pass through only still being a mixdown option btw. More flexibility. I also liked the ability to add different mixdowns on the extra track. However given that the ATV won't play them - I don't really care.
[21:09] [jbrjake] oh you'll definitely be able to in the future
[21:09] [jbrjake] this is just 0.9.2
[21:09] [eddyg] ok - I'm good with that.
[21:10] [eddyg] I'm glad you didn't change the way that libhb worked.
[21:10] [eddyg] I looked at changing acodec -> acodec[8]
[21:10] [eddyg] but it was going to be too much change.
[21:10] *** jbrjake wants to see job->acodecs[8] after 0.9.2
[21:10] [jbrjake] hahah typed that before reading what you wrote
[21:10] [eddyg] The mixdowns worked a lot more cleanly
[21:10] [eddyg] :)
[21:11] [jbrjake] i think it's really confusing in libhb for now, because of those structural limitations
[21:11] [eddyg] Yep -
[21:11] [jbrjake] it bends my mind to consider ac3 pass-thru a kind of aac encoding ;
[21:11] [eddyg] audio needs to become a structure that contains the mixdown and bitrate etc.
[21:11] [eddyg] Yep - it was just easier that way - as you could tell from the diffs.
[21:11] [eddyg] Because mixdowns were already [8]
[21:12] [jbrjake] yeah, path of least resistance
[21:12] [jbrjake] you have a chance to look at how i did it in the cli? a bit slap-dash, but i'll revisit for 0.9.3
[21:12] [eddyg] and the GUI already had a menu per track.
[21:12] [eddyg] I'll take a look - just awoke.
[21:13] *** jbrjake likes that hb has enough developers spread out across enough time zones that development is only down for like 5 hours a day :-)
[21:14] [jbrjake] saintdev: what ever happened with mkv chapter markers and perian?
[21:15] [eddyg] Interesting the way the extra tracks are added.
[21:15] [eddyg] (from the CLI)
[21:16] [eddyg] quite nice really.
[21:17] [eddyg] Very tidy, well done.
[21:20] [eddyg] dynaflash: So you're going to ditch ac-3 pass through as a mixdown option?
[21:20] [eddyg] Personally I like it there, as long as it is not the default.
[21:20] [eddyg] Just below the mixdown code in Controller.mm is where we set the default mixdown.
[21:21] [eddyg] Which is DPLII
[21:21] [dynaflash] well, not necessarily, I would like to have it be under a different codecs option though
[21:21] [dynaflash] as it really doenst belong uner avc / aac
[21:21] [eddyg] if we change that to aac+ac3 when this new hybrid codec then that would be nice.
[21:21] [eddyg] That's easy as well.
[21:21] [dynaflash] I have, patch is above
[21:21] [eddyg] OK.
[21:22] [eddyg] As jbrjake says, it is useful if you are only playing through an ATV with DD support and the computer to ditch the AAC track altogether.
[21:22] [eddyg] Although I'm sure it will be a bit of a support pain.
[21:23] [eddyg] The other thing I was thinking about.. AC-3
[21:23] [eddyg] Do our users really know what AC-3 is? And should they care?
← back next →
1 2 3 4
up
Generated by logs2html module for eggdrop v.2.3.4
Find latest version at http://sourceforge.net/projects/logs2html or http://shmupsik.osetia.org